search

dnault / therapi-runtime-javadoc

Read Javadoc comments at run time.
Apache License 2.0
117 stars 19 forks source link

Add visitor pattern to Comment and CommentElements #47

Closed kirkch closed 4 years ago

kirkch commented 4 years ago

As discussed in #31 . The advantage of this pattern is that it removes the need for using instanceof within the CommentFormatters.

kirkch commented 4 years ago

This is the last of the PRs that I have for the time being. Let me know if there is anything else that I can help with. Once they have all gone in, please consider a release candidate.

dnault commented 3 years ago

Hi @kirkch , I noticed you closed the link import PR; sorry I wasn't quick enough on that one. Thank you for doing the pathfinding.

In the mean time, version 0.12.0 with your other changes is live on Maven Central. Cheers!

kirkch commented 3 years ago

Wonderful news re 0.12.0 going out.

It would be good to see the import resolution work complete at some point. I am having an operation on Tuesday which will take me out of commission for a while, and I expect that my backlog of other life business will keep me fully booked into the new year. In which time I am hoping that somebody will figure out how to resolve imports during the compiler phase. Please keep me in the loop with the progress that gets made.

On Sun, 18 Oct 2020 at 05:59, David Nault notifications@github.com wrote:

Hi @kirkch https://github.com/kirkch , I noticed you closed the link import PR; sorry I wasn't quick enough on that one. Thank you for doing the pathfinding.

In the mean time, version 0.12.0 with your other changes is live on Maven Central. Cheers!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dnault/therapi-runtime-javadoc/issues/47#issuecomment-711116953, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE6BOIO2XU77RBXSDUFQWLSLJY2XANCNFSM4RTCB62A .

dnault commented 3 years ago

@kirkch Good luck with the operation; here's wishing for a speedy recovery.

bbottema commented 2 years ago

@dnault, @kirkch, I have an elaborate (and stateful) ContextualCommentFormatter subclass which doesn't compile anymore with this change, but I have no idea how I'm supposed to replace that with the new pattern.

Can we have some migration notes, or a little bit more elaborate example?

dnault commented 2 years ago

@bbottema The most straightforward path would be to copy the source code of CommentFormatter from 0.11.0 into your own project and extend that instead.