search

dnault / therapi-runtime-javadoc

Read Javadoc comments at run time.
Apache License 2.0
117 stars 19 forks source link

Remove external dependencies at all #49

Closed magdel closed 3 years ago

magdel commented 3 years ago

https://github.com/dnault/therapi-runtime-javadoc/blob/584558dd2fee1ccda5528d66b70b949243356515/build.gradle#L20

Hello! I just wonder if it is possible to remove dependency at all and have nice pure Java library.

dnault commented 3 years ago

Hi Pavel,

I'm not sure I see the benefit of implementing our own JSON library.

The minimal-json library is shaded/shadowed into the therapi-runtime-javadoc JAR, repackaged to avoid any possible dependency conflicts:

https://github.com/dnault/therapi-runtime-javadoc/blob/584558dd2fee1ccda5528d66b70b949243356515/build.gradle#L27-L31

From a user's perspective, the therapi-runtime-javadoc library has no external dependencies. You can verify this by inspecting the published POM.

Thanks, David

magdel commented 3 years ago

@dnault , thank you.