search

dnault / therapi-runtime-javadoc

Read Javadoc comments at run time.
Apache License 2.0
117 stars 19 forks source link

#50: fix mismatch between paramtypes when trying to locate matching M… #55

Closed bbottema closed 2 years ago

bbottema commented 2 years ago

This fixes the paramtype comparison for Java >= 8 (Java < 8 remains working, of course)

dnault commented 2 years ago

Thank you for this. I fear it won't work for everyone, since the behavior of TypeMirror.toString() depends on the JDK.

For example, when I reproduce the problem on my machine, instead of "(<annotationName> :: <className>)" I see "<annotationName> <className>".

I shared some more thoughts over on https://github.com/dnault/therapi-runtime-javadoc/issues/50#issuecomment-1003140334

bbottema commented 2 years ago

That's unfortunate. Either we adopt a few variations to capture all known (popular) implementations, or we go the way of JavaPoet's strategy (although admittedly, I haven't look into it extensively, so I'm not sure how well it covers current JVM's).