search

dnault / therapi-runtime-javadoc

Read Javadoc comments at run time.
Apache License 2.0
117 stars 19 forks source link

[fix] check empty or not first before enhancement from super #68

Closed yanxiyue closed 2 years ago

yanxiyue commented 2 years ago

if there are inner class which has $ in className, the method ClassJavadoc#createEnhancedClassJavadoc (issue #61 )throws Exception because ClassJavadoc#createEmpty do not replace $.

So, I think that should check empty or not first.

In addition, some eclipse config files have been added to the .gitignore file

dnault commented 2 years ago

Hi yanxiyue. I'm grateful for your investigation and PR.

It turns out there was another problem (https://github.com/dnault/therapi-runtime-javadoc/issues/70) with the "is empty" logic. Commit 2a8bc27bf391a884f1430fea0b0d5b757b1b250a resolves both issues, but I will credit you in the release notes for version 0.15.0.

Would you like to open a separate PR for just the .gitignore changes?