dnbaker / dashing

Fast and accurate genomic distances using HyperLogLog
GNU General Public License v3.0
160 stars 11 forks source link

Unable to install (error with make file) #30

Closed seanaller closed 4 years ago

seanaller commented 4 years ago

Hi there,

I'm having an issue when attempting to install dashing via make dashing

I get the following error:

make: *** No rule to make target bonsai/hll/include/cbf.h', needed bysrc/dashing.o'. Stop.

Any suggestions?

dnbaker commented 4 years ago

It sounds like you didn't clone recursively; we use submodules as a way of providing dependencies. You can fix this by running git submodule update --init --recursive from the directory where you cloned it, or, alternatively, delete the dashing directory and git clone --recursive https://github.com/dnbaker/dashing && cd dashing && make dashing.

I've updated the README to reflect this better; in refactoring, I left the verbal instruction to clone recursively but didn't update the build commands.

Let me know if you have any further problems!

seanaller commented 4 years ago

It sounds like you didn't clone recursively; we use submodules as a way of providing dependencies. You can fix this by running git submodule update --init --recursive from the directory where you cloned it, or, alternatively, delete the dashing directory and git clone --recursive https://github.com/dnbaker/dashing && cd dashing && make dashing.

That was exactly it! Thanks for that.