Sketch compressed - bug fix + byseq

dnbaker / dashing2

Dashing 2 is a fast toolkit for k-mer and minimizer encoding, sketching, comparison, and indexing.

MIT License

62 stars 7 forks source link

Sketch compressed - bug fix + byseq #39

Closed dnbaker closed 2 years ago

dnbaker commented 2 years ago

Fix allocation bug in setsketch (aligned_alloc requires argument 2 be divisible by argument 1).

This also allows for --setsketch-ab/--fastcmp-nibbles/--fastcmp-bytes/--fastcmp-shorts to be used in --parse-by-seq mode.

This sacrifices the ability to tune the setsketch parameters to the data, but it can reduce peak memory requirements/total size available substantially.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging dfb11368eb1560dbd420586c6904cdc5f5495057 into f422525ac464ef516d6890926bd176fff6abbab5 - view on LGTM.com

new alerts:

1 for Multiplication result converted to larger type