search

dnbert / prm

PRM Allows you to quickly build package repositories, inspired by Jordan Sissels' FPM
MIT License
250 stars 33 forks source link

The generate flag doesn't do anything #29

Closed mfoo closed 10 years ago

mfoo commented 10 years ago

I had a look at bin/prm, and I'm pretty sure the --generate flag, while referred to in the documentation, does nothing. Am I mistaken?

dnbert commented 10 years ago

Hey there! Sorry for the delay in responding, naturally life catches up to me at the most inopportune times. :)

The --generate flag is there for legacy purposes than anything else, in the initial release I had it to make sure I wasn't building repos when testing commands. Do you think its time to get rid of it?

mfoo commented 10 years ago

If it does nothing, I think it should removed, but make sure that calling with --generate doesn't throw an exception. Perhaps print a deprecation warning to stderr.

If it's pointless it should be removed from the documentation too, I just don't want to break people's existing packaging systems.

dnbert commented 10 years ago

https://github.com/dnbert/prm/commit/1fad05659070527d9d37cc4fe13b34df4d7f9a71 should take care of this! In version 0.3.0 (when I implement Solaris Package support) we'll remove --generate completely.