Fix for + signs in filenames within S3-hosted apt repositories

dnbert / prm

PRM Allows you to quickly build package repositories, inspired by Jordan Sissels' FPM

MIT License

249 stars 31 forks source link

Fix for + signs in filenames within S3-hosted apt repositories #46

Closed jgoldschrafe closed 9 years ago

jgoldschrafe commented 9 years ago

Amazon S3 has a bug wherein it treats the + character in the path component of all URLs as a space, rather than a distinct path character. As a result, all + characters must be encoded to %2B in order to be accessible on S3.

Per Amazon's official proposed solution, this patch forcibly URL-encodes all RFC 3986 characters that are part of the filename so generated repositories function correctly on S3 even when package filenames contain the + character.

dnbert commented 9 years ago

Thanks for the patch! Sorry it took so long to respond