search

dnbexperience / eufemia

DNB Design System
https://eufemia.dnb.no
Other
53 stars 31 forks source link

fix(ChildrenWithAge): sync summary and edit container #3950

Closed tujoworker closed 1 month ago

tujoworker commented 1 month ago

This PR is based on #3949

It adds also support for:

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ❌ Failed (Inspect) Sep 17, 2024 11:14am
codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

langz commented 1 month ago

Looks good. Perhaps we should first merge the following PR #3946 to main(I think that PR is ready for merging), then rebase this PR #3950 with main, and then add docs to the properties tab for the showEmpty property in this PR #3950?

PR #3946 is now merged to main 💯

langz commented 1 month ago

I'll do some more testing of this PR now, meanwhile to better understand what the expected change/output is, I've created a PR documenting the existing functionality of the ChildrenWithAge Summary with screenshot tests - https://github.com/dnbexperience/eufemia/pull/3954

langz commented 1 month ago

Tested now, it looks good 🏁 It's sort of breaking, as we change the default/basic behavior to not showing empty values, but since blocks is sort of beta(Note: If you are interested in using blocks, please get in touch with us.), I think it's safe to do so .

tujoworker commented 1 month ago

:tada: This PR is included in version 10.50.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: