search

dnbexperience / eufemia

DNB Design System
https://eufemia.dnb.no
Other
53 stars 32 forks source link

Container card outline broken in Wizard #4308

Open andlbrei opened 1 day ago

andlbrei commented 1 day ago

💥 Regression Report

ViewContainers have a outline even when using variant="basic", which it did not have previously. This style is overridable with outline=basic generally, but not within a Wizard.

bilde

10.55.0 added a style for nested cards, which might be the culprit. https://github.com/dnbexperience/eufemia/pull/4244

Last working version

Worked up to version: 10.54

Stopped working in version: 10.55

To Reproduce

https://codesandbox.io/p/sandbox/optimistic-https-6kffvm

Expected behavior

I expect Container components to not have an outline when setting variant="basic".

langz commented 1 day ago

Probably related to https://github.com/dnbexperience/eufemia/pull/4244 🤔

tujoworker commented 1 day ago

Yes, I think too that we did not catch the change in the visual snapshot. But it is fixed in the main branch already.

tujoworker commented 4 hours ago

This is fixed and released in v10.57 – here is an example (the second one).

andlbrei commented 56 minutes ago

@tujoworker @langz This is still an issue in version 10.57.0 bilde

tujoworker commented 36 minutes ago

:tada: This issue has been resolved in version 10.57.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

andlbrei commented 28 minutes ago

Not sure if 10.57.1 was supposed to fix it, or if this was automagically sent by mistake, but it's still not fixed 😅