fix #5 : checkboxes for type multi are deselected when query is parsed

dncrews / angular-elastic-builder

This is an Angular.js directive for building an Elasticsearch query. You just give it the fields and can generate a query for it.

Other

83 stars 38 forks source link

fix #5 : checkboxes for type multi are deselected when query is parsed #6

Closed oguennec closed 8 years ago

oguennec commented 8 years ago

Hi @dncrews , this fixes issue #5 which appeared with commit e79a94b

I have suggested a fix without using the truthy logic in the commit.

With the truthy logic, a double bang is needed before tilde: prev[choice] = (truthy === (!!~group[key][obj.field].indexOf(choice)));

oguennec commented 8 years ago

Hello @dncrews,

Please find another commit -> fix #7: date format parsed from query to builder defaults to current date with fixed format.

With this fix :+1:

a format of a date field in an existing query is now parsed by angular-momentjs using the date format specified next to the field
queries with multiple date formats are now parsed successfully into the builder
new dependencies have been introduced for date format parsing from query : angular-momentjs and momentjs.

dncrews commented 8 years ago

@oguennec: Sorry it took me so long to look at this. Separate features will need to be separate PRs. Can you separate these?

oguennec commented 8 years ago

@dncrews : no worries. As requested I am about to submit 2 PR from 2 features branches. Please note that the 2nd PR includes the 1st PR commit (src/services/QueryService.js is modified in both PR). Let me know if this is fine or not.