search

dncuug / X.PagedList

Library for easily paging through any IEnumerable/IQueryable in ASP.NET
https://andrew.gubskiy.com/open-source
MIT License
899 stars 213 forks source link

AjaxOptions.LoadingElementId - "#" is NOT prepended automatically #221

Closed liawcv closed 1 year ago

liawcv commented 2 years ago

Class = X.PagedList.Web.Common.AjaxOptions

Property = UpdateTargetId --> "#" is prepended automatically.

Property = LoadingElementId --> "#" is NOT prepended automatically.

Example:

var o = new AjaxOptions { HttpMethod = "get", UpdateTargetId = "target", LoadingElementId = "#loader", // Inconsistency };

adschmu commented 3 months ago

This has been reverted in f3745d8 See the commit message for details.

I understand that this Issue was about consistency, so there was no use-case that was blocked by the prepend.

If there are any (e.g. use a class as target), please post here so we can discuss them. Please only present actual use cases and no theoretical ones. ;-)