dncuug / X.PagedList

Library for easily paging through any IEnumerable/IQueryable in ASP.NET
https://andrew.gubskiy.com/open-source
MIT License
899 stars 213 forks source link

X.PagedList.Mvc.Core: Revert behavior for UpdateTargetId #264

Closed adschmu closed 3 months ago

adschmu commented 3 months ago

This reverts commit 01d9633478dcd06e267d466e71145d030cdb5ffa.

In [1], behavior for the UpdateTargetId was changed so the "#" symbol is not prepended anymore and one has to add it manually now. However, the very name "UpdateTargetId" indicates that this is an ID and not something else. Similar behavior is found for JavaScript, where a function name containing "Id" implies that the hash symbol is not required.

Revert this to the previous behavior (<= 8.4.7), so it can be used without changes coming from any version except 9.1.2. This implements the correct behavior as it implies the provided value is actually an ID.

Future alternate solutions as discussed in #245 might choose different names to accept arbitrary elements as argument (e.g. UpdateTarget to accept IDs, classes, etc.).

Note that examples never got updated anyway (and thus no need to revert them).

[1] 01d9633478dc ("Close #221")

Fixes: #245