Task 2 - Githubissues

dnemirich / python_course

Homeworks for Python course (1st term)

0 stars 0 forks source link

Closed dnemirich closed 6 years ago

dnemirich commented 6 years ago

@YakutovDmitriy Second homework is done, check it, please

YakutovDmitriy commented 6 years ago

Tests for hw-1: you have SyntaxError. Also you have a warning from pep8. Please fix these issues
Function goodPairs do not work on some tests. Please think about it.
Other functions are ok!

dnemirich commented 6 years ago

I tried to repeat tests of goodPairs and it showed correct answers for all tests

YakutovDmitriy commented 6 years ago

Your implementation of goodPairs works on sample tests. But there exists a test:

dnemirich commented 6 years ago

Changed goodPairs a little, check, please

YakutovDmitriy commented 6 years ago

goodPairs is ok!
Remind you that you are to fix tests for hw1 and fix code of hw1 such that pep8 will be satisfied with your code

dnemirich commented 6 years ago

Fixed hw1

YakutovDmitriy commented 6 years ago

Almost fixed :( Do you run your code before commiting? You code contains some syntax errros

dnemirich commented 6 years ago

Just fixed syntax errors, forgot to commit them earlier

YakutovDmitriy commented 6 years ago

Ok, second hw is ok!