Task 9

[dnemirich]

Hi, I just made a Task 9. Sorry, for being so late, but if you have time, could you check it, please?

[YakutovDmitriy]

Hello, Daria!

I hope you are ok, don't disappear anymore please!

• FSItem.rename and FSItem.create. To do?
• File.__init__. You raise an Error when file is already exist. Actually initialization of new File-instance is not about creation of new file in OS, so it is possible to create a new File-instance in python if path is valid path to existing file. But it is absolutely incorrect to create File-instance if path is path to existing directory. So you need to change the condition of raising this error a bit
• File.getcontent. It is ok. But I recommend you to rewrite this method a bit. It is better to close file after opening
• Directory.__init__. The similar issue as in File.__init__
• Directory.filesrecursive. You have a bug here. Try to execute this method (and iterate over yielded objects!) to find it
• Directory.getsubdirectory. Something strange happens here
  • Line 110: global new, why do you need this? I have SyntaxWarning here, I guess this is a bug
  • self has no field new as I can see