search

dnephin / dobi

A build automation tool for Docker applications
https://dnephin.github.io/dobi/
Apache License 2.0
309 stars 36 forks source link

ignore .dobi directory when computing build context modified time #168

Closed lhuhn-wish closed 4 years ago

lhuhn-wish commented 4 years ago

If we want to use dobi to build our repo, it makes sense to put the dobi.yaml in the same repo, but unfortunately the docker context is in the root of the repo. dobi creates a .dobi directory in the same dir as the dobi.yaml file to track various things, which triggers rebuilds every time when files change under .dobi.

Let's just ignore .dobi and everything under it when computing the docker build context age.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

lhuhn-wish commented 4 years ago

Whoops wanted PR against my repo copy, not upstream.

flcdrg commented 4 years ago

I think I'm having the same problem. I'm curious why you didn't go ahead with the PR?

lhuhn-wish commented 4 years ago

@flcdrg I need to work with my company to get the CLA sorted.

lhuhn-wish commented 4 years ago

CLA is signed.

dnephin commented 4 years ago

CI was failing, I tried rebasing this PR on the latest master to see if that helps.

dnephin commented 4 years ago

Thank you for the PR!

I guess this will match any directory called .dobi, but it's somewhat unlikely that there are other directories with that name, so it's probably not a big concern right now.