search

dnephin / dobi

A build automation tool for Docker applications
https://dnephin.github.io/dobi/
Apache License 2.0
309 stars 36 forks source link

feat(image): push action authenticates against each tag #172

Closed Fuco1 closed 4 years ago

Fuco1 commented 4 years ago

The tag argument is expanded with t.config.Image if it only contains the part after :. If it is the entire image name this is used instead. In both cases the argument contains the registry which we can extract and auth against.

fixes #170

claassistantio commented 4 years ago

CLA assistant check
All committers have signed the CLA.

Fuco1 commented 4 years ago

@dnephin Do you think it would be possible to tag a new version? I'd like to update my build scripts to make use of these new features.

I'm slowly getting into go development (we are building some terraform providers at work now) so I'm looking forward to contributing more to dobi!

dnephin commented 4 years ago

I've tagged a new version, but the CI pipeline to upload binaries to the github release is failing because of some problem uploading to github. If all you need is the tag you should be all set!

Fuco1 commented 4 years ago

Well I need the binary :D But I can wait if it's a github problem.

dnephin commented 4 years ago

I figured out what I was doing wrong, the binaries are up now: https://github.com/dnephin/dobi/releases/tag/v0.13.0

Fuco1 commented 4 years ago

Thanks Daniel, awesome!