dnephin / dobi

A build automation tool for Docker applications
https://dnephin.github.io/dobi/
Apache License 2.0
311 stars 36 forks source link

Dobi cache does not appear to save very much time #229

Open aidan-mundy opened 3 years ago

aidan-mundy commented 3 years ago

The dobi cache was created back when docker loaded the entire build context before building the image. Build context loading and caching is now scoped only to files used in the ADD/COPY commands, so is now much quicker. The upgrades to docker seem to have made dobi's cache obsolete. Additionally, docker images that ADD files from remote sources appear to be handled incorrectly by dobi. The remote file should be downloaded and checked for caching purposes before assuming the image is fully cached. This is handled by docker automatically.

Does it make sense for the dobi cache to remain a feature as it currently appears today?

dnephin commented 3 years ago

I think given the improvements to docker build it does make sense to remove the dobi cache.