dnet / adsdroid

Unofficial AllDataSheet Android application
https://techblog.vsza.hu/posts/Unofficial_Android_app_for_alldatasheet.com.html
MIT License
29 stars 11 forks source link

[FR] change download destination #15

Closed ildar closed 6 years ago

ildar commented 6 years ago

Probably here: https://github.com/dnet/adsdroid/blob/f12ed6d8f4f27791a2797288d595bab515040d75/src/hu/vsza/adsdroid/PartList.java#L85 I like the app, are you going to support it further?

dnet commented 6 years ago

You got it right, it could be implemented there. The question is, what UI should be used for this?

AFAIK as Android has no system-wide/platform-provided Save file UI like common dialogs in Microsoft Windows, it's not a trivial move. Do you have an example maybe in another app that you think is intuitive and works well? I'd prefer if it's FLOSS, so that we could take the component as-is without having to reimplement it and/or face legal issues.

I like the app, are you going to support it further?

For me, it's doing its job well, so I don't have plans of my own. However, I accept pull requests, and selectively implement feature requests, if I have the time. Is that a yes?

ildar commented 6 years ago

This is "yes-yes!". :) Then could you please check if it works good? I can't get a datasheet with https://github.com/dnet/adsdroid/releases/tag/v1.6.2

ildar commented 6 years ago

IMHO this doesn't need any UI: I suggest just using the standard /sdcard/Download folder, or precisely, `Environment.getExternalStorageDirectory()