dnfield / lottie-flutter

A pure Dart/Flutter implementation of Lottie
Apache License 2.0
115 stars 24 forks source link

In compatible with current flutter_svg version #24

Open greatpie opened 5 years ago

greatpie commented 5 years ago

Because every version of lottie_flutter depends on path_drawing ^0.2.1, flutter_svg ^0.12.0 is incompatible with lottie_flutter.

dnfield commented 5 years ago

Oof. I really should do a cleanup here. I'll try to do something quick with that today.

dnfield commented 5 years ago

I took a look at this but managed to break the build for it locally. If you can, try using a dependency_override and it should be fine - in the mean time I'm looking at alternative approaches.

GianlucaCesari commented 5 years ago

Any news on this? I too encountered the same problem and not knowing how dependency_override works i had to bump down flutter_svg to 0.5.0 , the problem is all my svg are now broken 😅

@dnfield can you maybe post a snippet to let us know how we can use dependency_override in this case?

dnfield commented 5 years ago

Something like this should work:

environment:
  sdk: ">=2.1.0 <3.0.0"

dependencies:
  flutter_svg: ^0.12.0
  lottie_flutter: any
  flutter:
    sdk: flutter

dependency_overrides:
  path_drawing: ^0.4.0
GianlucaCesari commented 5 years ago

Thank you @dnfield :)