search

dnhkng / GlaDOS

This is the Personality Core for GLaDOS, the first steps towards a real-life implementation of the AI from the Portal series by Valve.
MIT License
3.04k stars 285 forks source link

GlaDOS gets interrupted by itself when on speaker #38

Closed Sgnarf closed 6 months ago

Sgnarf commented 6 months ago

If I run GlaDOS with speaker and microphone, it hears itself speaking and assume that's the answer (e.g. the first few word of the response become the input) getting stuck in a forever loop.

The issue is not there if using headset+mic, where it can't hear its own answers.

I don't know if it's a system issue (I'm currently on Windows) or if it can be managed within the GlaDOS libraries...

dnhkng commented 6 months ago

This needs a noise cancelling microphone. A room speaker system is needed.

dnhkng commented 6 months ago

I have created a new branch that makes interruption optional in #39. That should stop the loop problem, but prevents you from interrupting GLaDOS.

Could you test it out, and see if if solves your issue?

bitbyteboom commented 6 months ago

May be a good idea add note in README of need for noise canceling setup or headphones / headset for interruption to work.

dnhkng commented 6 months ago

I added that to the 'Help Section' on the new branch.

Sgnarf commented 6 months ago

I've cheked the new version and with interruptible = false it does work. However the "user experience" is a bit different, as you can't interrupt the model if it starts rambling about stuffs :D

dnhkng commented 6 months ago

Yes, thats how is works.

If you find the answers too long, go ahead and modify the system prompt and ask for shorter responses.