dnhn / df-fe-23

https://dffe23-dn-7.vercel.app
1 stars 0 forks source link

Assignment 1 #2

Open dnhn opened 12 months ago

dnhn commented 12 months ago

https://dffe23-dn-1.vercel.app

trankhacvy commented 11 months ago

Hello @dnhn , great work!

Requirements

Final result: ✅ passed

Feedback

We also have some comments for your work:

  1. Your UI has some differences from our required UI. While your functions still work, it's important to align with the requirements. We appreciate new ideas, but please communicate them with us in advance.

2. Consider placing the JSON.parse function within a try-catch block. This approach will help you handle unexpected errors more smoothly.

You also deserve praise 🔥 for showcasing excellent UI/UX. You're the first to implement the empty state for the table. Keep up the great work!

dnhn commented 11 months ago

@trankhacvy thank you for your review, I appreciate it. However, I believe there is a mistake here, try-catch is already added and tested.

  1. Consider placing the JSON.parse function within a try-catch block. This approach will help you handle unexpected errors more smoothly.

https://github.com/dnhn/df-fe-23/blob/11c8faa027d4fc6d85ee50c7d17cc3ab16cb9eed/assignment-1/script.js#L3-L9

trankhacvy commented 11 months ago

@dnhn you're right. My bad. Thank you for letting me know.