search

dniym / IllegalStack

A spigot based plugin dedicated to fixing glitches and exploits that have made it into final Minecraft releases.
GNU General Public License v3.0
148 stars 36 forks source link

Add MC 1.20 Support #166

Closed DerMistkaefer closed 1 year ago

DerMistkaefer commented 1 year ago

Add Support for the new Minecraft 1.20 Version

DerMistkaefer commented 1 year ago

As you requested, I have revised the version checks so that no adjustments to the two functions, isRelevantToVersion and isVersionSpecific, are required for new versions anymore. Unfortunately, I don't understand the subversion query in isVersionSpecific, so I have left it in to preserve the old functionality.

Loving11ish commented 1 year ago

Hi there does this pr also contain the folia support code?

dniym commented 1 year ago

https://github.com/dniym/IllegalStack/pull/166/commits/f341763c2887046a0aaf8b78895df3b71137b68a

looks like its in there, it should be as the folia code was in before this.

DerMistkaefer commented 1 year ago

Sorry, yesterday I didn't was on GitHub.

Something like > 1.12 / < 1.19 won't work as expected. Yes there are cases where we can need it, but in general is such string checking a little bit illegal. I don't know if we want to support that. I also like to have unit tests for the method.

The Folia Support is included and should work for Folia 1.20. (I didn't test it)

I just joined your Discord, I am also there present as @dermistkaefer