dnnrly / abbreviate

Supporting your devops by shortening your strings using common abbreviations and clever guesswork
Apache License 2.0
220 stars 17 forks source link

Adding Flag for removing stopwords #35

Closed leafoliage closed 1 year ago

leafoliage commented 1 year ago

Description

This PR adds a flag --stopwords, which removes stopwords from abbreviation.

Fixes #33

Type of change

How Has This Been Tested?

I’ve created a test for the removeStopwords function.

Checklist:

ghost commented 1 year ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=35&src=https%3A%2F%2Fgithub.com%2Fdnnrly%2Fabbreviate)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

dnnrly commented 1 year ago

Thanks for this new feature @leafoliage - and apolgies for taking so long to merge it. As is tradition, if you do twitter then please let me know your handle and I will git you a follow. :smile:

leafoliage commented 1 year ago

@dnnrly Thank you too for approving this PR! Here's my twitter handle: leafoliage