() Characters that are not illegal are considered illegal characters

[aelibyary]

Fixes #1029

Summary

This issue is very obscure. The error message is misleading.

The URL is rejected because of a hidden host setting named AUM_ReplaceChars which has a default value of &$+,/?~#<>()¿¡«»!" (including a space at the beginning)

URLs are tested against the above characters. In a nutshell, the above characters are replaced with a hyphen when found in the URL.

The other aspect of this issue is that the validation logic returns a suggested modified URL to the front-end, which is completely ignored.

@daguiler Suggested:

I think the easiest way to fix this without introducing breaking changes is 1- to change the error message so that it doesn't specify which characters are "illegal", (Fixed) 2- and also, replace the user-provided URL with the suggested modified URL in case there were validation errors. (Fixed)

Fix Video

[dnfclas]

All CLA requirements met.

[v-karbovnichy]

@bdukes @valadas @mitchelsellers @daguiler can someone merge this, it has 2 approvals already.

[valadas]

As far as I know we are waiting to release 9.4.0 before creating the 9.4.1 branch and then we will start merging, correct ?

[v-karbovnichy]

So this is the expected events timeline:

• make release 9.4.0 from release/9.4.x
• merge this PR into release/9.4.x
• make release 9.4.1 from release/9.4.x

correct?

[mitchelsellers]

Correct

[valadas]

It is my understanding too

[valadas]

@aelibyary this is currently targetting development which means it would be included in Dnn 10, would you like to re-target the release/3.0.x branch for inclusion in Dnn 9.4.1 ?

[aelibyary]

@aelibyary this is currently targetting development which means it would be included in Dnn 10, would you like to re-target the release/3.0.x branch for inclusion in Dnn 9.4.1 ?

Hello @valadas , #1166 has been created to target release/3.0.x branch