dnnsoftware / Dnn.AdminExperience

DNN (formerly DotNetNuke) Combined Admin Experience
MIT License
17 stars 39 forks source link

IP address filtering UI is not reflecting the settings correctly #1078

Closed tingung closed 5 years ago

tingung commented 5 years ago

Description of bug

IP address filtering UI is not reflecting the settings correctly.

Steps to reproduce

List the steps to reproduce the behavior:

  1. Go to Settings -> Security -> Member Accounts -> Member Management
  2. Toggle "On" Enable IP Address Checking And Save
  3. Go to Settings -> Security -> Login Settings ->Login IP Filters
  4. Click "Add New Filters"
  5. Enter 192.168.0.1 into "First IP"
  6. Click "Save"
  7. Edit the filter

Current result

First IP input text field is blank. Similar behavior for other fields.

Expected result

First IP input text field should display the saved value. Other fields should display the saved value.

Screenshots

If applicable, provide screenshots to help explain your problem. image Reproduction video - https://drive.google.com/open?id=140U9IJAe5kN4SIgxRzIy6fe2GBUgoYHE

Error log

Paste the error log that is related to this issue.

Additional context

Add any other context about the bug that may be helpful for resolution.

Affected version

Affected browser

valadas commented 5 years ago

Oh, I just saw this after duplicating the issue, ignore the other one...

This relates to https://github.com/dnnsoftware/Dnn.Platform/issues/2922 which also needs to be fixed for this to work properly.

tingung commented 5 years ago

Hi @valadas ,

I will fix 2922 with another PR because it need to change not only the UI validation but the server side. This issue is not reported by the client but I found it when I am manually test the IP Filter.

valadas commented 5 years ago

Merged