search

dnnsoftware / Dnn.AdminExperience

DNN (formerly DotNetNuke) Combined Admin Experience
MIT License
17 stars 39 forks source link

DNN-29429: Fix SMTP Server Tab UI Issue #1091

Closed kkadir closed 5 years ago

kkadir commented 5 years ago

Fixes #1090

Summary

The <div className="tooltipAdjustment border-bottom"> tags are moved after the smtpSettingsVisible flag. This assures that a horizontal-line is visible only if that block is visible.

Confirmation Video

dnfclas commented 5 years ago

CLA assistant check
All CLA requirements met.

mitchelsellers commented 5 years ago

@kkadir Any chance this change could get resubmitted aginst the 3.0.0 release branch? We are still working some items for 9.4.0 and I would like to get this in?

kkadir commented 5 years ago

Hello @mitchelsellers, sorry for the delay, sure I will rebase it right away.

kkadir commented 5 years ago

Rebasing it messed the PR so please close this one as I will open a new PR based on the 3.0.X Release branch.

mitchelsellers commented 5 years ago

Will do! FYI - This will come as part of 9.4.1, as we have closed 9.4.0 items.

kkadir commented 5 years ago

1124 created with the same changes based on release/3.0.x, also thanks for the update @mitchelsellers.