search

dnnsoftware / Dnn.AdminExperience

DNN (formerly DotNetNuke) Combined Admin Experience
MIT License
17 stars 39 forks source link

DNN-28934: Fix Export to PDF Issue on SQL Console Issue #1093

Closed kkadir closed 5 years ago

kkadir commented 5 years ago

Fixes #1092

Summary

The word-based encoding/rendering option getWords(characters) is removed as it should always be based on characters only to wrap long texts without separators and/or spaces.

Confirmation Video

valadas commented 5 years ago

Taking a very quick looks at their current version, I do not even see that method in the code, so I guess there was some major updates in later releases. Maybe upgrading the library would be a better solution to this problem. @kkadir I am closing this PR but keeping the issue open if you have time to try out the new version, it would be a better PR.

kkadir commented 5 years ago

Thank you for your updates @bdukes and @valadas.

But the 3rd-party jsPDF was not included as a library nor a package but instead included into the module as a *.js file. That is why I did not consider it as a 3rd-party library update.

Please also note that the current update will only affect SQL Console as the updated jsPDF belongs only to that module and other modules have their own jsPDF.js files. So it will be great if you can reconsider this PR, thanks in advance!