search

dnnsoftware / Dnn.AdminExperience

DNN (formerly DotNetNuke) Combined Admin Experience
MIT License
17 stars 39 forks source link

DNN-31578 - Deleted page can still be selected as parent page - second repository #1099

Closed berkarslan-xo closed 5 years ago

berkarslan-xo commented 5 years ago

Partially Fixes https://github.com/dnnsoftware/Dnn.Platform/issues/2919 (There are total of 2 PRs; for the other PR, you can check: https://github.com/dnnsoftware/Dnn.Platform/pull/2925 ).

Summary

A new parameter named as "includeDeletedChildren" is added to filter out the deleted child pages.

Demo: https://drive.google.com/open?id=1yg6OuVuLMbwCbBlFHXDqQa8Abd3WPIn_

Note: This PR should be merged AFTER https://github.com/dnnsoftware/Dnn.Platform/pull/2925. CI fails since the dependent PR is not merged yet.

valadas commented 5 years ago

/azp run

azure-pipelines[bot] commented 5 years ago
Azure Pipelines successfully started running 1 pipeline(s).
mitchelsellers commented 5 years ago

/azp run

azure-pipelines[bot] commented 5 years ago
Azure Pipelines successfully started running 1 pipeline(s).
berkarslan-xo commented 5 years ago

CI fails since it requires https://github.com/dnnsoftware/Dnn.Platform/pull/2925 to be merged first. I suppose packages.config needs to be updated after the merge too.

valadas commented 5 years ago

Hmm, I was sure that got merged, it is now, but we need to wait for dependabot then we will be able to merge this. @mitchelsellers when you have a minute, if you can rerun the pipeline with publish task enabled, Dependabot should update the PRs to this new one after I merged the PR in Platform. Thanks

valadas commented 5 years ago

/azp run

azure-pipelines[bot] commented 5 years ago
Azure Pipelines successfully started running 1 pipeline(s).