search

dnnsoftware / Dnn.AdminExperience

DNN (formerly DotNetNuke) Combined Admin Experience
MIT License
17 stars 39 forks source link

Adds checksums for 9.4.0 Platform #1118

Closed valadas closed 5 years ago

valadas commented 5 years ago

Closes #1076

Adds checksums for 9.4.0 Platform default.aspx so the security analyser succeeds checking it

mitchelsellers commented 5 years ago

@valadas This should target the 3.0.x branch, and also seems to include some clutter

valadas commented 5 years ago

Oh, what happened there, I will resubmit...

valadas commented 5 years ago

Oh, I know what happened, I targeted development instead of release/3.0.0 if you can re-review please :)

bdukes commented 5 years ago

Any idea why the checksum is different here? We didn't implement a change to Default.aspx, did we?

bdukes commented 5 years ago

Looks like https://github.com/dnnsoftware/Dnn.Platform/commit/0cf1b13b2f076b6f7314142c1778ca97c267ba0 introduced a blank line at the end of the file, even though the other change in that commit was reverted (https://github.com/dnnsoftware/Dnn.Platform/commit/75254183340731513228a1508068c608c15ffa2b)