DNN-31960: Fix Collapse All Issue After Moving Away The Only Child

dnnsoftware / Dnn.AdminExperience

DNN (formerly DotNetNuke) Combined Admin Experience

MIT License

17 stars 39 forks source link

DNN-31960: Fix Collapse All Issue After Moving Away The Only Child #1123

Closed kkadir closed 5 years ago

kkadir commented 5 years ago

Fixes #1122

Summary

On expand/collapse toggling, assure that childListItems, isOpen and hasChildren attributes are removed for parent nodes without children.

Confirmation Video

Note

This includes code-changes also from #1113 to keep them as separate PRs so that they can be merged separately without requiring any sequence.

kkadir commented 5 years ago

Please note that normally this requires #1113 to be merged first. But to keep it separate, I created this intermediate PR based on that feature branch. Hence; this PR and #1113 may be merged separately or in any order.

kkadir commented 5 years ago

Hello @valadas, @bdukes; it would be nice if you can review this PR, just a friendly reminder :)

mitchelsellers commented 5 years ago

This is targeting the 'Development' branch which is for consideration for 10.0 release, we will resume reviewing these PR's after the 9.4.0 release.

mikebigun commented 5 years ago

Dear community, let me know please if you have any concerns on this?

mitchelsellers commented 5 years ago

@mikebigun this one was not merged as it targets development

mikebigun commented 5 years ago

This can be closed in favor of https://github.com/dnnsoftware/Dnn.AdminExperience/pull/1176

daguiler commented 5 years ago

Closing