search

dnnsoftware / Dnn.AdminExperience

DNN (formerly DotNetNuke) Combined Admin Experience
MIT License
17 stars 39 forks source link

Fix tab sorting before they are serialized #1134

Closed donker closed 5 years ago

donker commented 5 years ago

Fixes #1133

Summary

The tabs Hashtable is being built while exporting the portal's tabs. Further down the code the tab's parent is expected to be in the tabs Hashtable. If this fails the export stops. With the current sorting a newer tab (i.e. higher tabid) as a parent of an older tab (lower tabid) will cause this process to fail. Sorting should be on level, not tabid.

mitchelsellers commented 5 years ago

@donker Is the intention for this to be held until 10.x? If not, can you rebase this to Release 3.0.x branch?

donker commented 5 years ago

@donker Is the intention for this to be held until 10.x? If not, can you rebase this to Release 3.0.x branch?

I don't think it's too urgent since there is no UI for it right now.