search

dnnsoftware / Dnn.AdminExperience

DNN (formerly DotNetNuke) Combined Admin Experience
MIT License
17 stars 39 forks source link

Unable to set membership settings "Use Email Address as Username" ON #1137

Closed aelibyary closed 5 years ago

aelibyary commented 5 years ago

Fixes #1135

Summary

This issue is very obscure. The error message is misleading.

RC: The saving of the settings is being rejected because of a data issue not a code issue, So to be able to reproduce this issue, you've first to create 2 users with the same Email Address, and as long as the system allows something like that, you won't probably expect that this might be the root cause of this settings problem,

Current behavior: From UI perspective we actually get a response from the server saying what exactly is the issue, however we ignores this error and simply show a default error message "Could not update the registration settings. Please try later."

Proposed solution: Showing an error tool tip beside the failing setting displaying exactly the validation error occured (the response from the server)

Confirmation Video: https://drive.google.com/file/d/17Dfs_JYOfrxvw2T-4wG4ipNWm-Idwjgz/view

aelibyary commented 5 years ago

PR #1143 has been created as per @daguiler request above.