search

dnnsoftware / Dnn.AdminExperience

DNN (formerly DotNetNuke) Combined Admin Experience
MIT License
17 stars 39 forks source link

Edit module settings under Page Settings in Persona Bar opens blank pages #1148

Closed thabaum closed 5 years ago

thabaum commented 5 years ago

image

Description of bug

When you click on a module setting gear or the pencil for HTML Editor module while viewing page settings it opens a blank page.

Steps to reproduce

List the steps to reproduce the behavior:

  1. Go to Page Settings
  2. Select a page
  3. Navigate tabs to Advanced > Modules
  4. Click on the gear icon for settings or the pencil for edit of any module

Current result

Browser opens a blank page

Expected result

Ability to edit and view module settings and edit the module when that option is available.

Screenshots

If applicable, provide screenshots to help explain your problem.

Error log

Paste the error log that is related to this issue.

Additional context

Add any other context about the bug that may be helpful for resolution.

Affected version

Affected browser

marco756 commented 5 years ago

Fix to do in project Dnn.PersonaBar.Extensions > file: Dnn.AdminExperience.Extensions\src\Modules\Content\Dnn.PersonaBar.Pages\admin\personaBar\scripts\bundles\pages-bundle.js

value: function() { var e = this.iframeRef, t = e.contentWindow.location.href; if (-1 === t.indexOf("popUp")) this.closeOnEndRequest ? this.props.onUpdatedModuleSettings() : this.redirectUrl(t); else { var n = e.contentWindow.Sys.WebForms.PageRequestManager.getInstance(); if (typeof BeginRequestHandler == "function") n.add_beginRequest(this.beginRequestHandler.bind(this)); if (typeof EndRequestHandler == "function") n.add_endRequest(this.endRequestHandler.bind(this)) }

Added if (typeof BeginRequestHandler == "function") if (typeof EndRequestHandler == "function")

valadas commented 5 years ago

I can reproduce and I am moving this to AdminExperience repository @marco756 if you could submit that fix as a pull request, it would be awesome

valadas commented 5 years ago

There was some changes with some javascript stuff and I cannot reproduce this issue in 9.4.1, I am closing this issue but if you are still experiencing issues after 9.4.1 please open a new one.