Closed SergeyDryomin closed 5 years ago
I am just wondering if this is the right place for the fix. Social groups existed before the persona bar so I am guessing there is code in the core already for handling that.
I am not a 100% sure since I do not use social features much, but just trying to see if there would be a way to move this into the core. Was this bug pre-existing before the persona bar ? If so was this logic part of the UI too before ? Just trying to avoid duplication and breaking changes.
I believe the persona bar code should be more UI focused and everything else should be in the core to allow other extensions to benefit from the fix.
@valadas, in DNN 6, Social Groups had been piggypacked onto Security Roles (although they are totally different objects), and I am not sure, whether some of the functionality might have been implemented in Roles admin module - and might not have been properly migrated to the PB module. Anyways, if we ever touch Social Groups in DNN, we should move them to dedicated objects (database table) with references to member role, manager role etc.
Hi , @valadas @sleupold , implementation part can be moved to https://github.com/sergeydryomin/Dnn.Platform.git into DNN Platform\Library\Security\Roles\RoleController.cs
@sergeydryomin will you be submitting a PR there ?
Social Groups created through the Persona Bar do not appear in the Social Groups fixed https://github.com/dnnsoftware/Dnn.Platform/issues/3007 https://jira.devfactory.com/browse/DNN-30220
Summary
1) Create the role with Security Mode = Social Group, Status = Approved, Public 2) Get RoleID and UserId from created role. 3) Add Groups folder, if it doesn't exists. Add the folder with name equal to RoleID. 4) Add creator as owner to the Social Group(role)