search

dnnsoftware / Dnn.AdminExperience

DNN (formerly DotNetNuke) Combined Admin Experience
MIT License
17 stars 39 forks source link

UI issue for pages Expand All/Collapse All links #1183

Closed mikebigun closed 5 years ago

mikebigun commented 5 years ago

Description of bug

Expand All/Collapse All link in persona bar pages tree section is displayed as selected and highlighted by default. Regression found in the following PR https://github.com/dnnsoftware/Dnn.AdminExperience/pull/229. Instead of just making Expand/Collapse link clickable when child nodes loaded, the style of link was also changed in a way to make it highlighted regardless of state.

Steps to reproduce

  1. Install DNN Platform from scratch
  2. Login as super user
  3. Go to Persona Bar -> Pages

Current result

Pages screen is displayed. Expand All link in pages tree section is displayed as selected and highlighted in blue color.

Expected result

Expand All should not be highlighted by default on Pages screen. Link should be highlighted depending on whether it is clicked or not.

Screenshots

image

Affected version

valadas commented 5 years ago

After discussing this, it would violate accessibility requirements due to lack of color contrast, sorry, closing this pr and issue for that reason.