dnnsoftware / Dnn.Platform

DNN (formerly DotNetNuke) is the leading open source web content management platform (CMS) in the Microsoft ecosystem.
https://dnncommunity.org/
MIT License
1.02k stars 745 forks source link

The word "DotNetNuke" exists in several language .resx files #2236

Closed EPTamminga closed 6 years ago

EPTamminga commented 6 years ago

Description

DotNetNuke is the old name of DNNPlatform. Several .resx files still contain the word DotNetNuke i.s.o. DNNPlatform.

Steps to reproduce

Text search in the unzipped install pack on .resx files containing the word DotNetNuke

Current result

A list of files containing that word

Expected result

No files found

Affected version

Affected browser

sleupold commented 6 years ago

EPT, do you have a list of files? Are you referring to resx files included with DNN or separate language packs?

EPTamminga commented 6 years ago

@sleupold The basic .resx files in the install .zip:

GlobalResources.resx Authentication.ascx.resx Settings.ascx.resx Installwizard.aspx.resx Installwizard.aspx.de-DE.resx Installwizard.aspx.es-ES.resx Installwizard.aspx.fr-FR.resx Installwizard.aspx.it-IT.resx Installwizard.aspx.nl-NL.resx UpgradeWizard.aspx.resx UpgradeWizard.aspx.de-DE.resx UpgradeWizard.aspx.es-ES.resx UpgradeWizard.aspx.it-IT.resx UpgradeWizard.aspx.nl-NL.resx Default Website.template.en-US.resx

I have not analyzed the different language packs, but I assume they contain the word DotNetNuke as well

sleupold commented 6 years ago

I know, there were a few occurrences of DotNetNuke introduced in DNN 9, but I tried to replace them by DNN in the German LP whenever I noticed it.

sleupold commented 6 years ago

I just checked an install of DNN 9.2.0 and you are correct. I will take care of the German files, Do you plan to submit a PR for the English files or should I take care of it?

mitchelsellers commented 6 years ago

There are cases where the copyright notice for the older name should still be included in the texts. DO we know what/where this usage exists?

EPTamminga commented 6 years ago

@sleupold I am willing to generate PR's for all occurrences. The 'DotNetNuke' word in the .resx files is almost always related to the introductory text and not related to copyright notices.

If there is a legal notice that requires DotNetNuke as a word, I will leave the text as is.

@mitchelsellers Is the word DNNPlatform the right word to replace the word DotNetNuke?

sleupold commented 6 years ago

@EPTamminga please do not modify the resource files in other languages, this should be done by the translators - I'll make sure, the installwizard and upgradewizard resx files get copied over, once they are provided (there is a risk, they will be overwritten by the translators otherwise)

mitchelsellers commented 6 years ago

@EPTamminga it would depend on the context. DNN is the actual registered trademark, but it is often referred to as DNNPlatform. (Such as this repository)

EPTamminga commented 6 years ago

@sleupold OK, good to notice. I will only create a PR for the English versions.

sleupold commented 6 years ago

@EPTamminga thanks a lot!

sleupold commented 6 years ago

regarding the trademark: in the translation, I usually call it "DNN" and avoid using the name too often. Be aware it will be used for Platform, Evoq and maybe other distributions as well.

EPTamminga commented 6 years ago

Pull Request #2240 submitted

valadas commented 6 years ago

I would be nice to have the actual core language packs for the provided languages in Github, I know there are teams assigned to localization but when a user of a specific language spots a problem, he could submit a pull request and those officially assigned to that team could merge it in. I remember seeing many references to host and admin menus in some place of the french language pack, those references are no longer valid with the persona bar. Those things are very time consuming to work on independently but as users of different languages spot these during usage they could submit a quick pull request for a small correction.

EPTamminga commented 6 years ago

We (XCESS) are the official translators for Dutch. I tried this before (https://github.com/XCESS-NL/DNN.nl-NL). The repoaitory includes a gitignore that enables to have a normal full DNN installation locally and only sync Dutch resx files if you have a correction. I did some promotions in various channels, without success. The official translators have (Windows) tools made by @donker to make differential translations more efficient (changed, new, deleted text, statistics). If we want community contributions for translation (I favor that), we must do more than put a language pack in a repo.

sleupold commented 6 years ago

there are changes in progress for the translation process. I expect, we might open up the process at the end. ATM there is a verification procedure at ESW for generating the language pack from the translation files, we will need to substitute.