dnnsoftware / Dnn.Platform

DNN (formerly DotNetNuke) is the leading open source web content management platform (CMS) in the Microsoft ecosystem.
https://dnncommunity.org/
MIT License
1.02k stars 747 forks source link

Editing in HTML module doesn't show files for image manager #3004

Closed jncraig closed 2 years ago

jncraig commented 5 years ago

Description of bug

See https://dnncommunity.org/forums/aft/333#1438

Steps to reproduce

List the steps to reproduce the behavior:

  1. Clean DNN 9.4.0 installation
  2. Edit HTML Module
  3. Browse Server

Current result

only Root folder is shown

Expected result

All folders and files should be shown.

See details in https://dnncommunity.org/forums/aft/333#1438

Screenshots

If applicable, provide screenshots to help explain your problem.

Error log

It's in the thread mentioned

Additional context

Add any other context about the bug that may be helpful for resolution.

Affected version

Affected browser

sleupold commented 5 years ago

Did you sync database with file system and check folder permission (both in DAM)?

jncraig commented 5 years ago

Yes, multiple times.

The installation was done using nvQuickSite.

On Wed, Sep 18, 2019 at 2:24 PM Sebastian Leupold notifications@github.com wrote:

Did you sync database with file system and check folder permission (both in DAM)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dnnsoftware/Dnn.Platform/issues/3004?email_source=notifications&email_token=ABEDMRK7ZKF6Y57TW3QYJ6DQKJW5TA5CNFSM4IYBLL6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7A75KY#issuecomment-532807339, or mute the thread https://github.com/notifications/unsubscribe-auth/ABEDMRJU5QW722CPJPWAHRTQKJW5TANCNFSM4IYBLL6A .

valadas commented 5 years ago

I cannot reproduce in 9.4.0

@jncraig Can you check if the permissions on those subfolders (and the root folder maybe too) are like this: image

jncraig commented 5 years ago

After my clean install, the Root folder had no privileges for All users, but had full privileges for Administrators.

I added a Browse permission for All Users, and the directory structure appeared when I edited a HTML module. (Clear Cache, Restart)

I removed the Browses permission for All Users and, after clearing the cache and restarting the site, things still work correctly.

I created a Test directory under Root and uploaded a jpg file to the new directory. I also uploaded a jpg to Root. The file uploaded to Root is not visible. After a number of pokings around, the file in Root is not visible (even after adding back the Browse permission).

On Thu, Sep 19, 2019 at 3:06 AM Daniel Valadas notifications@github.com wrote:

I cannot reproduce in 9.4.0

@jncraig https://github.com/jncraig Can you check if the permissions on those subfolders (and the root folder maybe too) are like this: [image: image] https://user-images.githubusercontent.com/6371568/65221162-6cf75000-da8a-11e9-8d32-34c4d2888c11.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dnnsoftware/Dnn.Platform/issues/3004?email_source=notifications&email_token=ABEDMRKSGV2K3O2XJ2MUOWDQKMQHNA5CNFSM4IYBLL6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7CONSQ#issuecomment-532997834, or mute the thread https://github.com/notifications/unsubscribe-auth/ABEDMRIHLDX5IFB3UTNICUTQKMQHNANCNFSM4IYBLL6A .

valadas commented 5 years ago

Strange, do you have any other pointers to figure this out?

jncraig commented 5 years ago

Basically I don't know.

The person who posted in the forum said they saw only Root, no folders below it and no files.

I did a clean install, and basically saw the same thing. I used nvQuickSite to do the install (quick and easy).

I went to site assets and fiddled with permissions, it started working, and I put permissions back and it continued to work.

I have jpg files in Root and don't see them. Yes, I even try selecting Root. I see jpgs in a folder I created.

I didn't look for errors.

If I get some energy tomorrow, I'll try to do the whole thing again and see if I can repeat.

On Thu, Sep 19, 2019 at 4:56 PM Daniel Valadas notifications@github.com wrote:

Strange, do you have any other pointers to figure this out?

  • Are there differences in the filenames that work and don't (special characters) ?
  • Are there errors in the browser console ?
  • Are there interesting logs in Portals/_default/logs ?
  • Are there errors in the Admin Logs ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dnnsoftware/Dnn.Platform/issues/3004?email_source=notifications&email_token=ABEDMRPPNNFKWCUIOYC7WILQKPROZA5CNFSM4IYBLL6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7EZVIY#issuecomment-533306019, or mute the thread https://github.com/notifications/unsubscribe-auth/ABEDMRKG2EF6NSKNIAYY57DQKPROZANCNFSM4IYBLL6A .

valadas commented 5 years ago

In the spirit of cleaning the backlog I am closing this issue, if you can come up with more details or an accurate way to reproduce, feel free to comment here or open a new issue.

jncraig commented 4 years ago

I tested this in a clean install of 9.4.1. The problem is still there.

Please reopen.

valadas commented 4 years ago

If we cannot reproduce, reopening the issue as is will only jam the backlog.

After my clean install, the Root folder had no privileges for All users, but had full privileges for Administrators.

This part does not happen for me... Anyone else can see this happening?

Basically I don't know.

The person who posted in the forum said they saw only Root, no folders below it and no files.

Did you open this issue for an issue someone else is having, just trying to figure out how to make it happen here and if it could be environment related...

Are there differences in the filenames that work and don't (special characters) ? Are there errors in the browser console ? Are there interesting logs in Portals/_default/logs ? Are there errors in the Admin Logs ?

There was no reply to these questions, we need some way to make this issue actionable in order to reopen or it will just never get resolved...

jncraig commented 4 years ago

I have been able to reproduce this on two different computers with 9.4.1.

When I get a chance I'll try to document this better, but may be a couple of weeks.

Basically, install 9.4.1 and go to edit a HTML module. I generally install a blank site and edit an empty HTML module on the home page. Click the image tool, browse server for an image and you'll see only the root folder. Create a folder, it works but you cant see it. Upload an image into the root folder, and you won't be able to see that either.

TopCat6 commented 4 years ago

I have confirmed this issue on two servers as well, one a localhost and one production, both 9.4.1.

valadas commented 4 years ago

Guys, please add details, if developers cannot reproduce the issues, they just increase the backlog and the issue will never get resolved. Please reply to these questions as a starter:

Are there differences in the filenames that work and don't (special characters) ? Are there errors in the browser console ? Are there interesting logs in Portals/_default/logs ? Are there errors in the Admin Logs ?

TopCat6 commented 4 years ago

DNN 9.4.1, updated from 9.3.2. To produce issue:

  1. Edit an HTML module's content.
  2. Click the insert image button on the toolbar.
  3. Click the 'Browse Server' button.
  4. Notice that the only folder you can see is the 'Root' folder, with no ability to access subfolders.

Admin Logs show no entries for this process/time-frame. Browser console errors are as follows `JQMIGRATE: Migrate is installed with logging active, version 3.0.0 jquery-migrate.js:18:36 JQMIGRATE: jQuery.expr[":"] is now jQuery.expr.pseudos jquery-migrate.js:62:12 console.trace() jquery-migrate.js:64:13 jQuery 5 JQMIGRATE: jQuery.expr.filters is now jQuery.expr.pseudos jquery-migrate.js:62:12 console.trace() jquery-migrate.js:64:13 jQuery 6 JQMIGRATE: jQuery.fn.bind() is deprecated jquery-migrate.js:62:12 console.trace() jquery-migrate.js:64:13 jQuery 3 migrateWarn bind hoverIntent dnnModuleActions http://localhost/dotnetnuke/admin/menus/ModuleActions/ModuleActions.js?cdv=1282:402 setUpActions http://localhost/dotnetnuke/Home/ctl/Edit/mid/3417?popUp=true:85

http://localhost/dotnetnuke/Home/ctl/Edit/mid/3417?popUp=true:195 jQuery 2 dispatch handle ` The above warnings happen when the HTML editor loads. No additional entries are logged when the 'insert image' button is clicked on the toolbar. I tried this on two production systems and one localhost test system all with essentially the same result. The production system using dependency handlers was slightly different: `The script from “https://website.ca/dnn.controls.dnntoolbar.js” was loaded even though its MIME type (“text/html”) is not a valid JavaScript MIME type. Loading failed for the Githubissues.
  • Githubissues is a development platform for aggregating issues.