dnnsoftware / Dnn.Platform

DNN (formerly DotNetNuke) is the leading open source web content management platform (CMS) in the Microsoft ecosystem.
https://dnncommunity.org/
MIT License
1.01k stars 745 forks source link

[Enhancement]: Non conforming favicon meta tags #6011

Closed fcmss closed 2 months ago

fcmss commented 2 months ago

Is there an existing issue for this?

Description of problem

In current DNN version, the favicon meta tags uses <link rel="SHORTCUT ICON" href="[FAVICON LINK]" type="image/x-icon"> which is incorrect according to MDN website:

[!NOTE] Note: The shortcut link type is often seen before icon, but this link type is non-conforming, ignored and web authors must not use it anymore.

Description of solution

Solution is relatively simple, unless DNN somehow relies on the rel="SHORTCUT ICON", but the solution is just to change it to rel="icon" or rel="icon shortcut".

Description of alternatives considered

No response

Anything else?

No response

Do you be plan to contribute code for this enhancement?

Would you be interested in sponsoring this enhancement?

Code of Conduct