dnnsoftware / Dnn.Platform

DNN (formerly DotNetNuke) is the leading open source web content management platform (CMS) in the Microsoft ecosystem.
https://dnncommunity.org/
MIT License
1.01k stars 745 forks source link

[Bug]: Casing mismatch on DotNetNuke.Log4Net.dll #6024

Open valadas opened 2 months ago

valadas commented 2 months ago

Is there an existing issue for this?

What happened?

When running CI builds on Ubuntu for 3rd party extensions, the nuget package reference uses DotNetNuke.log4net but the assembly has a different casing of DotNetNuke.Log4Net.dll

Windows considers them the same but it fails in ubuntu builds.

We should harmonize the casing in our source code.

Steps to reproduce?

I don't have a public repo to show this but could create one if needed.

Current Behavior

No response

Expected Behavior

No response

Relevant log output

Error: [xUnit.net 00:00:05.31]     UnitTests.Services.Logging.LoggingServiceTests.LoggingService_DefaultConstructorExists [FAIL]
  03:24:18 [ERR] [xUnit.net 00:00:05.31]     UnitTests.Services.Logging.LoggingServiceTests.LoggingService_DefaultConstructorExists [FAIL]
  03:24:19 [DBG]   Failed UnitTests.Services.Logging.LoggingServiceTests.LoggingService_DefaultConstructorExists [4 ms]
  03:24:19 [DBG]   Error Message:
  03:24:19 [DBG]    System.IO.FileNotFoundException : Could not load file or assembly 'DotNetNuke.log4net, Version=3.0.2.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies.
  03:24:19 [DBG]   Stack Trace:
  03:24:19 [DBG]     at SomeClient.Modules.SomeModule.Services.LoggingService.SetupLogger (System.Type type) [0x00023] in <e33f3ccfe8824e628424bd4ad3e70f7b>:0 
  03:24:19 [DBG]   at SomeClient.Modules.SomeModule.Services.LoggingService.LogError (System.String message, System.Type type) [0x00007] in <e33f3ccfe8824e628424bd4ad3e70f7b>:0 
  03:24:19 [DBG]   at SomeClient.Modules.SomeModule.Services.LoggingService.LogError (System.String message) [0x00029] in <e33f3ccfe8824e628424bd4ad3e70f7b>:0 
  03:24:19 [DBG]   at UnitTests.Services.Logging.LoggingServiceTests.LoggingService_DefaultConstructorExists () [0x00006] in <b2c5da340f124c239b14b703464b5801>:0 
  03:24:19 [DBG]   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  03:24:19 [DBG]   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <d636f104d58046fd9b195699bcb1a744>:0

Anything else?

No response

Affected Versions

9.13.3 (latest release)

What browsers are you seeing the problem on?

Chrome

Code of Conduct