dnnsoftware / Dnn.Platform

DNN (formerly DotNetNuke) is the leading open source web content management platform (CMS) in the Microsoft ecosystem.
https://dnncommunity.org/
MIT License
1.01k stars 745 forks source link

[Bug]: Date format incorrect when Language set to English (United Kingdom) #6029

Open puresystems opened 1 month ago

puresystems commented 1 month ago

Is there an existing issue for this?

What happened?

On the following views, the date format for English (United Kingdom) is incorrect:

Manage->Users The "Joined" date format on the users list is incorrect, it's showing as mm/dd/yyyy

Manage->Roles->Users in Role The "Start" and "Expires" date format is incorrect, it's showing as mm/dd/yyyy

Steps to reproduce?

  1. Go to Settings->Site Settings->Languages
  2. Add "English (United Kingdom)" and set it to be the Site Default
  3. Set "Enable Language" = off for "English (United States)"
  4. Save Settings
  5. View Manage->Users list and observe the date format

Current Behavior

Language Settings example: Languages

Expected Behavior

The date format should be dd/mm/yyyy

Relevant log output

n/a

Anything else?

No response

Affected Versions

9.13.3 (latest release)

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Code of Conduct

mavjt commented 3 weeks ago

This is happening for me as well. All of DNN's dates are showing in US date format, rather than UK which is the Language set on the portal.
It has happened on both an upgraded site and a clean install of 9.13.3

mitchelsellers commented 3 weeks ago

@mavjt did this work correctly in a prior version? If so, do you know what the last version was that you saw it working properly?

mavjt commented 3 weeks ago

Looking for UK dates in the User.. Joined column: v9.6.2 shows correctly Upgraded to v9.9.1 and it was showing incorrectly ie US format. I then took a clean v962 which showed UK dates, upgraded it to v972 and it still showed correctly. Then v980 and it showed INCORRECTLY. It is not just a problem for admin pages either, I use an Events plugin that uses DNN date format to display dates so is showing dates in the US format when our users are expecting UK.

mavjt commented 3 weeks ago

These seem to be the only mention of culture/localization in the 980 release: https://github.com/dnnsoftware/Dnn.Platform/pull/4265 https://github.com/dnnsoftware/Dnn.Platform/pull/4164

jasclar commented 3 weeks ago

Noted same issue. Was signed in as SuperUser account with "Preferred Locale" set to "English (United Kingdom)".