search

dnnsoftware / Dnn.Platform

DNN (formerly DotNetNuke) is the leading open source web content management platform (CMS) in the Microsoft ecosystem.
https://dnncommunity.org/
MIT License
1.01k stars 745 forks source link

[Bug]: Invalid resource files format #6051

Open vmasanas opened 1 month ago

vmasanas commented 1 month ago

Is there an existing issue for this?

What happened?

Some files on 9.13.3 (haven't looked at previous versions, but did not happen on 9.6) have a bad header specification.

The correct one should be: <?xml version="1.0" encoding="UTF-8"?>

but they have: Notice the HTTPS I have some tools to help with translating resx files that I noticed started failing because of this. According to this post https://stackoverflow.com/questions/75617680/why-cant-i-reference-xmlschema-as-https it's incorrect to link to the schema as https and it should be http ### Steps to reproduce? Check for this example file: \admin\Modules\App_LocalResources\Export.ascx.resx ### Current Behavior _No response_ ### Expected Behavior _No response_ ### Relevant log output _No response_ ### Anything else? _No response_ ### Affected Versions 9.13.3 (latest release) ### What browsers are you seeing the problem on? _No response_ ### Code of Conduct - [X] I agree to follow this project's Code of Conduct
mitchelsellers commented 1 month ago

Looks like this was changed back in 9.6.2 - https://github.com/dnnsoftware/Dnn.Platform/issues/3879

It looks like these should be changed back.

mitchelsellers commented 1 month ago

@vmasanas Is there a specific area that is breaking with the current values?

vmasanas commented 1 month ago

Nothing breaking within DNN just a tool I have on my own where I detected this. Not critical but I'd say this should be corrected since the current values are wrong.