dnnsoftware / Dnn.Platform

DNN (formerly DotNetNuke) is the leading open source web content management platform (CMS) in the Microsoft ecosystem.
https://dnncommunity.org/
MIT License
1.02k stars 746 forks source link

[Bug]: Add icon is huge in pages SEO tab #6116

Open ufoloko opened 3 weeks ago

ufoloko commented 3 weeks ago

Is there an existing issue for this?

What happened?

After install or upgrade last version 9.13.4, SEO section inside Advanced tab is showing in this way.

image

Icon and link for Add URL are not taking any style, so button is displaying very big.

Steps to reproduce?

1.- Install last version 9.13.4 or simple update any site to this last version.

2.- Edit any page settings

3.- Click on Advanced tab, then SEO tab.

Current Behavior

Button for Add URL is being showed very big, specially for the svg icon

Expected Behavior

Button for Add URL should be displayed in this way

image

Relevant log output

No response

Anything else?

This happen with last version 9.13.4, even if you install from zero or if you update a site.

Affected Versions

9.13.4 (alpha)

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Code of Conduct

valadas commented 3 weeks ago

Hmm, that probably got missed in this update: https://github.com/dnnsoftware/Dnn.Platform/pull/6099

The fix should be similar than what was done everywhere else but a file got somehow missed.

ufoloko commented 2 weeks ago

Hi @valadas digging a little i found something.

image

For some reason, that className is not being rendering in Pages.Web client component, that should be automatically generated by webpack.

Looking a little bit webpack settings, the only difference is Pages.Web component is to have those additional config lines on css-loader plugin

image

I checked all other client components and don´t have those lines, so probably there can be the issue.

Sadly i was not able to run webpack because im receiving a lot of issues or warnings when running yarn install, so im not able to check if removing the lines solve the problem

bdukes commented 2 weeks ago

You may want to try running corepack enable to make sure the correct version of Yarn is setup.

ufoloko commented 2 weeks ago

I already tried that, but it appears is not a yarn issue, is more related with node packages