[Bug]: Persona Bar does not use Resource files for "All Users" - Githubissues

dnnsoftware / Dnn.Platform

DNN (formerly DotNetNuke) is the leading open source web content management platform (CMS) in the Microsoft ecosystem.

https://dnncommunity.org/

MIT License

1.03k stars 751 forks source link

[Bug]: Persona Bar does not use Resource files for "All Users" #6119

Open Timo-Breumelhof opened 2 months ago

Timo-Breumelhof commented 2 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

I edited SharedResources.resx to fix #6091. This works for the Module permissions grid, but not the Persona Bar.

Steps to reproduce?

Edit SharedResources.resx and change "All Users to "Everyone"
Open the Permissions of Page in the Persona Bar
It still says "All Users" in the permissions grid.

Current Behavior

Persona Bar has the virtual role "All Users" text hard coded

Expected Behavior

The text should be loaded from the resource file SharedResources.resx

Relevant log output

No response

Anything else?

Related to #6091 and both should be fixed at the same time IMO. All users > Everyone change : https://dnncommunity.org/forums/future-development/dnn-ideas/quotall-usersquot-is-not-the-best-term-for-security/

Affected Versions

9.13.3 (latest release)

What browsers are you seeing the problem on?

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

bdukes commented 2 months ago

The current permission grid calls Localization.LocalizeRole on the role name. If the Persona Bar's RoleController API methods are updated to call that before returning to the frontend, that should get us pretty close.