search

dnouri / cuda-convnet

My fork of Alex Krizhevsky's cuda-convnet from 2013 where I added dropout, among other features.
http://code.google.com/p/cuda-convnet/
254 stars 147 forks source link

Compiling via cmake with MSVC #13

Closed bitxiong closed 10 years ago

bitxiong commented 10 years ago

Modified cmake scripts and added the finder module for pthread and mkl. One modification in the source to successfully compile.

dnouri commented 10 years ago

@kashif Can you take a look at this and let me know if this looks good to you? Thanks.

kashif commented 10 years ago

@dnouri sure no problem. The configuration still works under OSX which is a good sign. I'll try it on linux later tonight and then on Windows too. Perhaps we might be able to get rid of some OS specific cruft, i'll see perhaps with Cmake 3. But initially it looks good.

dnouri commented 10 years ago

Hey @kashif, do you have an update for us? TIA

kashif commented 10 years ago

Yes so the only thing I wanted to change would be the:

set(THREADS_PTHREAD_WIN32_INC "C:/cuda-convnet/pthreads-w32-2-9-1-release/Pre-built.2/include")

to see if it can be moved to the FindPthread.cmake but I suppose there is no default location to install pthreads on windows... in which case it should be fine.

So from my side its ok! :+1:

yjxiong commented 10 years ago

Any updates? Since the cuda-convnet2 is out. I guess we can also switch to that.

kashif commented 10 years ago

@dnouri we might as well merge this and i can then make a pull request with my suggestions