search

dnp3 / opendnp3

DNP3 (IEEE-1815) protocol stack. Modern C++ with bindings for .NET and Java.
https://dnp3.github.io
Apache License 2.0
300 stars 231 forks source link

Add IOutstationApplication::OnConfirmProcess to C++, C#, and Java #403

Closed jadamcrain closed 4 years ago

jadamcrain commented 4 years ago

This is my first stab at adding this feature. It was straightforward as the callback is only invoked from two places in OutstationStates.cpp

We might consider adding some tests to this PR to verify.

codecov[bot] commented 4 years ago

Codecov Report

Merging #403 into release will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           release     #403      +/-   ##
===========================================
+ Coverage    51.69%   51.75%   +0.05%     
===========================================
  Files          456      456              
  Lines        13602    13609       +7     
===========================================
+ Hits          7032     7043      +11     
+ Misses        6570     6566       -4
Impacted Files Coverage Δ
cpp/lib/src/outstation/event/EventBuffer.h 100.00% <ø> (ø)
...clude/opendnp3/outstation/IOutstationApplication.h 12.50% <100.00%> (+3.80%) :arrow_up:
cpp/lib/src/outstation/OutstationStates.cpp 73.33% <100.00%> (+1.05%) :arrow_up:
cpp/lib/src/outstation/event/EventBuffer.cpp 50.00% <100.00%> (+0.76%) :arrow_up:
cpp/lib/src/channel/IOHandler.cpp 80.15% <0.00%> (+3.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 639edaf...6034a89. Read the comment docs.