dnp3 / opendnp3

DNP3 (IEEE-1815) protocol stack. Modern C++ with bindings for .NET and Java.
https://dnp3.github.io
Apache License 2.0
300 stars 231 forks source link

Inconsistent return-types in CommandHeader.java #417

Closed OOPMan closed 2 years ago

OOPMan commented 3 years ago

Hi, the return-types in java/bindings/src/main/java/com/automatak/dnp3/CommandHeader.java seem a bit inconsistent.

The following return class CommandHeader:

The following return interface CommandHeaders:

This issue also applies to the

jadamcrain commented 3 years ago

It should just return the interface type CommandHeaders, not the impl type CommandHeader.

I think we can safely fix this in the next patch release as the impl type doesn't expose any additional methods.