dnp3 / opendnp3

DNP3 (IEEE-1815) protocol stack. Modern C++ with bindings for .NET and Java.
https://dnp3.github.io
Apache License 2.0
300 stars 231 forks source link

Deprecate `LinkConfig` constructor with an unused `useConfirms` argument. #439

Closed emgre closed 2 years ago

emgre commented 2 years ago

See https://groups.google.com/g/automatak-dnp3/c/CY_i9VGMMiY

codecov[bot] commented 2 years ago

Codecov Report

Merging #439 (c87d6df) into develop (e8b1de4) will decrease coverage by 0.02%. The diff coverage is 0.00%.

:exclamation: Current head c87d6df differs from pull request most recent head 8f72ac8. Consider uploading reports for the commit 8f72ac8 to get more accurate results

@@             Coverage Diff             @@
##           develop     #439      +/-   ##
===========================================
- Coverage    51.36%   51.34%   -0.03%     
===========================================
  Files          423      423              
  Lines        13444    13444              
===========================================
- Hits          6906     6903       -3     
- Misses        6538     6541       +3     
Impacted Files Coverage Δ
cpp/lib/include/opendnp3/link/LinkConfig.h 0.00% <0.00%> (ø)
...pp/lib/include/opendnp3/master/MasterStackConfig.h 0.00% <0.00%> (ø)
cpp/lib/src/app/PrefixedWriteIterator.h 95.23% <0.00%> (-4.77%) :arrow_down:
cpp/lib/src/gen/LinkFunction.cpp 65.82% <0.00%> (-2.54%) :arrow_down:
cpp/lib/src/app/parsing/CountIndexParser.cpp 59.74% <0.00%> (-0.65%) :arrow_down:
cpp/lib/src/transport/TransportLayer.cpp 95.31% <0.00%> (+1.56%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more