Build errors for aarch64-fsl-linux

[Vladimir-Ostapchuk]

Fixes aarch64-fsl-linux-g++ (Linaro GCC 4.9-2015.03) 4.9.3 20150311 (prerelease) were added.

[jadamcrain]

I made a change to the CI that should cause it to run on a PR. Can you try closing and opening again?

[Vladimir-Ostapchuk]

Hi Adam,

How are you?

Do you mean - close PR and create it again?

-- Best, Vladimir

On Mon, May 16, 2022 at 12:27 PM Adam Crain @.***> wrote:

I made a change to the CI that should cause it to run on a PR. Can you try closing and opening again?

— Reply to this email directly, view it on GitHub https://github.com/dnp3/opendnp3/pull/446#issuecomment-1127941255, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE6DRX2GG43UHEXBMUARCDVKKAQFANCNFSM5V4UFFVQ . You are receiving this because you authored the thread.Message ID: @.***>

[jadamcrain]

Yes please. I was hoping it would trigger the build when I edited ci.yml but it didn't. If it still doesn't work I'll try creating my own PR using your branch.

[Vladimir-Ostapchuk]

Another PR will be created for CI.

[codecov[bot]]

Codecov Report

Merging #446 (fcaf6f4) into release (1c7b827) will increase coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head fcaf6f4 differs from pull request most recent head 8e6930f. Consider uploading reports for the commit 8e6930f to get more accurate results

@@             Coverage Diff             @@
##           release     #446      +/-   ##
===========================================
+ Coverage    51.31%   51.33%   +0.01%     
===========================================
  Files          423      423              
  Lines        13458    13458              
===========================================
+ Hits          6906     6908       +2     
+ Misses        6552     6550       -2     

Impacted Files	Coverage Δ
cpp/lib/include/opendnp3/app/OctetData.h	100.00% <ø> (ø)
cpp/lib/src/channel/LoggingConnectionCondition.h	20.00% <ø> (ø)
cpp/lib/src/transport/TransportLayer.cpp	93.75% <0.00%> (ø)
cpp/lib/src/gen/QualifierCode.cpp	55.38% <0.00%> (+3.07%)	:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[Vladimir-Ostapchuk]

Hi Adam,

It did not pass [image: @github-actions] https://github.com/apps/github-actions CI / conformance (pull_request). Is it something I need to fix?

On Mon, May 16, 2022 at 12:49 PM Adam Crain @.***> wrote:

Yes please. I was hoping it would trigger the build when I edited ci.yml but it didn't. If it still doesn't work I'll try creating my own PR using your branch.

— Reply to this email directly, view it on GitHub https://github.com/dnp3/opendnp3/pull/446#issuecomment-1127962549, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZE6DRRPMFBWF3SFRWERS2TVKKDEJANCNFSM5V4UFFVQ . You are receiving this because you authored the thread.Message ID: @.***>

[jadamcrain]

The failure was unrelated to the C++ build. There are some issues w/ the CI but given that project is approaching EOL in September I'm not going to worry about it. I just wanted to ensure that the 3 main compilers were happy with the change.

[jadamcrain]

I'll do a final release w/ this and any other patches just before the EOL. thanks.