dns-violations / dnsflagday

DNS flag day
https://dnsflagday.net/
146 stars 40 forks source link

commit 1625608 is insufficient #132

Closed kidmin closed 4 years ago

kidmin commented 4 years ago

I read commit 1625608 makes sure the recommended buffer size is 1232. If so, the sentence in index.md

The value recommended here is 1232 bytes, though it is still up for discussion.

would be better to be updated, for example, removing the last clause.

The value recommended here is 1232 bytes.

It removes ambiguity that the buffer size is still under discussion.

I also updated Japanese translation to reflect the change above. I didn't touch the other translations because they are slightly outdated and I'm not sure it is grammatically OK to just remove a clause.

The branch also contains another trivial update.

vixie commented 4 years ago

the discussion is ongoing. see also:

https://tools.ietf.org/html/draft-fujiwara-dnsop-avoid-fragmentation-01

i oppose the proposed commit.

⁣Get BlueMail for Android ​

On 10 Oct 2019, 10:02, at 10:02, kidmin notifications@github.com wrote:

I read commit 1625608 makes sure the recommended buffer size is 1232. If so, the sentence in index.md

The value recommended here is 1232 bytes, though it is still up for
discussion.

would be better to be updated, for example, removing the last clause.

The value recommended here is 1232 bytes.

It removes ambiguity that the buffer size is still under discussion.

I also updated Japanese translation to reflect the change above. I didn't touch the other translations because they are slightly outdated and I'm not sure it is grammatically OK to just remove a clause.

The branch also contains another trivial update. You can view, comment on, or merge this pull request online at:

https://github.com/dns-violations/dnsflagday/pull/132

-- Commit Summary --

  • remove oversight "still up for discussion"
  • "Test!" button has been localized

-- File Changes --

M 2020/index-ja.md (4) M 2020/index.md (2)

-- Patch Links --

https://github.com/dns-violations/dnsflagday/pull/132.patch https://github.com/dns-violations/dnsflagday/pull/132.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dns-violations/dnsflagday/pull/132

jelu commented 4 years ago

@kidmin Thanks for the corrections.